Add support for JP MSR #272
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henriquegemignani
requested changes
Feb 1, 2025
dyceron
force-pushed
the
support-jp-msr
branch
from
1e8ccf0 to
45e757f
Compare
|
Is there anything else I need to do with this pr? All I can think of is adding the missing file names, or handling all the unknowns somehow. |
|
We need to add a copy of the JP version of the game to the build machine so the tests can run. |
|
I do have one |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely needs more things to be done, but doing the early steps. Mainly want feedback on this if this is the correct approach.