Fix Vec2/3/4 #286
Open
Fix Vec2/3/4 #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncathan
requested changes
Mar 20, 2025
| icon.sDisabledIconId = sDisabledIconId | ||
| icon.sInspectorLabel = sInspectorLabel | ||
| icon.vAnchorOffset = list(vAnchorOffset) | ||
| icon.vAnchorOffset = Vec2(*vAnchorOffset) |
There was a problem hiding this comment.
should probably just make this take a Vec2 as the argument
| return None | ||
| return ValueError(f"Invalid CVector{length}D: {__value}") | ||
|
|
||
| return None |
There was a problem hiding this comment.
you should keep this length check, since isinstance(Vec4(0.0, 0.0, 0.0, 0.0), Vec2) is true. the float check isn't strictly necessary but doesn't hurt
There was a problem hiding this comment.
Do we want that to explicitly fail? Shouldn't you be using type(Vec4(0.0, 0.0, 0.0, 0.0)) is Vec2 if you want to exclude subclasses?
There was a problem hiding this comment.
you could you use that instead of this length check if you prefer. still needs to be a special case tho
tests/test_type_lib.py
Outdated
| ("base::math::CVector2D", ["foo", "bar"], TypeError("Expected Vec2; got list")), | ||
| ("base::math::CVector2D", [0.0], TypeError("Expected Vec2; got list")), | ||
| ("base::math::CVector3D", [0.0], TypeError("Expected Vec3; got list")), | ||
| ("base::math::CVector4D", [0.0], TypeError("Expected Vec4; got list")), |
There was a problem hiding this comment.
likewise, add test cases where you pass a Vec3 and a Vec4 to a Vec2 field and ensure they error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.