Skip to content

Conversation

MayberryZoom
Copy link
Contributor

@MayberryZoom MayberryZoom commented Mar 6, 2025

Marking this as a draft as currently Storm Missiles are visually chargeable without Missile Launcher. They can't be shot, but removing this visual bug would be nice. If we can't find a way to do it and think it's okay to work this way, I'll mark this as ready for review.

Fixes #342

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (42ee71f) to head (50c588e).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   91.98%   91.99%           
=======================================
  Files          38       38           
  Lines        2159     2161    +2     
=======================================
+ Hits         1986     1988    +2     
  Misses        173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MayberryZoom MayberryZoom marked this pull request as ready for review March 6, 2025 20:30
Copy link
Contributor

@duncathan duncathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a launcher model already, which is great, but we'll need to add a map icon as well

@MayberryZoom
Copy link
Contributor Author

I pushed what I have for now, but I just noticed that the Missiles are taking priority over Supers/Ice for some reason. Checking the inventory, I had ITEM_WEAPON_SUPER_MISSILE, ITEM_WEAPON_ICE_MISSILE, and ITEM_WEAPON_SUPER_ICE_MISSILE but still shot normal missiles. No idea why, the priorities in samus.bmsad look correct to me.

@MayberryZoom MayberryZoom marked this pull request as draft March 18, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make shuffled missile launcher properly work

2 participants