-
Notifications
You must be signed in to change notification settings - Fork 14
Finish missile launcher implementation #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
=======================================
Coverage 91.98% 91.99%
=======================================
Files 38 38
Lines 2159 2161 +2
=======================================
+ Hits 1986 1988 +2
Misses 173 173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have a launcher model already, which is great, but we'll need to add a map icon as well
I pushed what I have for now, but I just noticed that the Missiles are taking priority over Supers/Ice for some reason. Checking the inventory, I had |
Marking this as a draft as currently Storm Missiles are visually chargeable without Missile Launcher. They can't be shot, but removing this visual bug would be nice. If we can't find a way to do it and think it's okay to work this way, I'll mark this as ready for review.
Fixes #342