Change minimum Speed Booster charge time #398
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
=======================================
Coverage 91.97% 91.97%
=======================================
Files 38 38
Lines 2156 2156
=======================================
Hits 1983 1983
Misses 173 173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ArcanoxDragon
added a commit
to ArcanoxDragon/randovania
that referenced
this pull request
Apr 4, 2025
…rd their description to account for randovania/open-dread-rando#398
duncathan
reviewed
Apr 4, 2025
| local chargeTime = math.max(0.25, 1.5 - quantity * 0.25) | ||
| -- Cannot be <= 0 or else all hell breaks loose. | ||
| -- SB activation is very buggy <= 0.5, so we clamp it a tiny bit higher. | ||
| local chargeTime = math.max(0.55, 1.5 - quantity * 0.25) |
There was a problem hiding this comment.
I haven't tried it, but that would only be one extra frame beyond when it has a problem (technically it'd be effectively rounded up to 0.5167). 0.55 is 3-4 frames extra.
ArcanoxDragon
added a commit
to ArcanoxDragon/randovania
that referenced
this pull request
Apr 23, 2025
…rd their description to account for randovania/open-dread-rando#398
… quirk where SB sometimes won't activate correctly after Samus turns around
ArcanoxDragon
force-pushed
the
fix/speed-booster-upgrades
branch
from
51b8688 to
c4acb81
Compare
zarakava
pushed a commit
to zarakava/randovania
that referenced
this pull request
May 1, 2025
…rd their description to account for randovania/open-dread-rando#398
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a well-known quirk when you have four or more Speed Booster Upgrades that causes Speed Booster to sometimes fail to activate when buffering it while Samus turns around. Bumping the minimum charge time up to 0.55 seconds seems to fix this in all of my testing, and there's nowhere in logic that requires >= 4 upgrades, so this shouldn't have any logical implications at all. The "effective" maximum number of upgrades you can collect is now 4 instead of 5, but 5 was even buggier than 4 was, so I don't think this is a bad thing.