Fixed corruption ScriptObject templates #198
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated RSOT to reorder some properties - changed string encoding to iso-8859-1 - two Relays in Elysia - Skytram East contain the tm character (0x99) - some strings contain raw data (FluidProperties.FluidLockString) - MREA p3 tests parse/build all SCLY
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 69.49% 69.50% +0.01%
==========================================
Files 88 88
Lines 5523 5523
Branches 764 764
==========================================
+ Hits 3838 3839 +1
+ Misses 1543 1542 -1
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: It does parse/build every MREA but it may not cover all possible values. iso-8859-1 has some bytes without proper encodings, and it seems like strings are actually bytestrings in engine. It's likely not to be required outside of niche romhack usage, and since it's a superset of ASCII it should suffice for most use cases.