Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: start to test PatriciaTrie#defrag again #225

Closed
wants to merge 2 commits into from

Conversation

otegami
Copy link
Contributor

@otegami otegami commented Jan 18, 2025

Because the bug is fixed in Groonga.

@otegami
Copy link
Contributor Author

otegami commented Jan 18, 2025

After Groonga 14.1.3 is released, the test will be passed.

@otegami otegami force-pushed the test-patricia-trie-defrag branch from eab3247 to 8d72e34 Compare February 5, 2025 09:04
@otegami
Copy link
Contributor Author

otegami commented Feb 5, 2025

@kou
Copy link
Member

kou commented Feb 5, 2025

Do we need this?
The test is enabled automatically with Groonga 14.1.3 without this.

@otegami
Copy link
Contributor Author

otegami commented Feb 12, 2025

Ahh I see. We don't need it.

  • def need_groonga(major, minor, micro)
    if (Groonga::BUILD_VERSION[0, 3] <=> [major, minor, micro]) < 0
    omit("Groonga #{major}.#{minor}.#{micro} or later is required")
    end
    end

@otegami otegami closed this Feb 12, 2025
@otegami otegami deleted the test-patricia-trie-defrag branch February 12, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants