Allow to add OpenSpout\Common\Entity\Cell instances as data collection values#306
Open
kusab85 wants to merge 2 commits intorap2hpoutre:masterfrom
Open
Allow to add OpenSpout\Common\Entity\Cell instances as data collection values#306kusab85 wants to merge 2 commits intorap2hpoutre:masterfrom
OpenSpout\Common\Entity\Cell instances as data collection values#306kusab85 wants to merge 2 commits intorap2hpoutre:masterfrom
Conversation
820e5a1 to
6ed8c5c
Compare
Apply StyleCI patch Fix Codacy Static Code Analysis Issues - The method exportOrDownload() has an NPath complexity of 300. The configured NPath comp1lexity threshold is 200. - The method exportOrDownload() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10. - Avoid using static access to class '\OpenSpout\Common\Entity\Row' in method 'writeHeader'. Fix test with 'ubuntu-latest, 8.1, lowest' build Extract Cell and Row creations to single methods Remove static Cell creation from Exportable trait Eat this Codacy Static Code Analyzer Enough joking , Codacy
6ed8c5c to
09d0381
Compare
|
@rap2hpoutre Oh I found this very helpful, could you please take a look at it for me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to feed FastExcel exporter (directly or via callback) with data consisting of instances of
OpenSpout\Common\Entity\Cell,which gives possibility to style every column (or even every cell) independently.
For example code like this:
gives:
Or code like this:
gives: