fix type incompatible bug when nochr is used #237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combin_counts.py
always usestr
type for#CHR
, as shown below.hatchet/src/hatchet/utils/combine_counts.py
Lines 110 to 112 in 3729a35
When
nochr
is enabled (reference/bam file doesn't havechr
prefix),to_dataframe()
inrd_gccorrect.py
will automatically useint64
dtype for column#CHR
, which is incompatible with#CHR
from dataframebb
, as shown below and from the issue #236.hatchet/src/hatchet/utils/rd_gccorrect.py
Lines 20 to 32 in 3729a35
This fix converts the dtype of
#CHR
tostr
postto_dataframe()
.