Update build infra; better testing with minimal deps; ruff format#489
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
- Coverage 98.45% 98.40% -0.06%
==========================================
Files 19 19
Lines 3376 3380 +4
Branches 497 497
==========================================
+ Hits 3324 3326 +2
- Misses 27 28 +1
- Partials 25 26 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There are two different pytest setups. One is called core and similar to the old one, but I removed some python versions. It tests different os and python versions with the newest dependency versions. The other one defines hard coded dependency versions for different python versions and for different os versions as well. For python 3.10 I tried to select the oldest dependencies possible/sensible. This needs more maintenance. But it already shows that pingouin is not compatible with old pandas and numpy versions. There is also a weird dependency resolution error with statsmodels. This leads to quite a lot of combinations. What do you think about that? Is it too much? Perhaps we could remove macOS or reduce the python versions for the core tests. (Moreover there is pre release setup that only runs on schedule or manually.) |
|
Thank you @yann1cks ! This is great.
|
|
I do not think it is possible to set a different line length for docstrings, see here. At least I do not know how to implement it. Having the |
|
@yann1cks please see my edits. All tests are passing ✅ Note that I had to bump pandas to 2.1.1 and statsmodels to 0.14.1 to avoid a bug on windows. |
| ] | ||
| dynamic = ["version"] | ||
| requires-python = ">=3.10" | ||
| dependencies = [ |
There was a problem hiding this comment.
I think the minimal package versions from the tests should be used for the dependencies as well.
|
Looks good to me. Just one comment about the required dependency versions in pyproject.toml. Additionally the contributing.rst needs a rewrite because it describes the old GitHub Actions and is incomplete. But I can tackle that in another PR. |
|
Thanks! I updated the contributing.rst file. I'll merge this PR when the tests are complete |
Hello @raphaelvallat,
this PR includes the updates I mentioned in #480 and some additional changes:
.atuvto speed it up. I removed the codecov token, because it is publicly available. I think you should rewoke this token.