fix: route backend events to hidden-tab panels#1631
Open
nikicat wants to merge 1 commit into
Open
Conversation
`ContextManager::get_by_route_id` only searched the active tab's grid, so any `RioEvent` that targets a specific `route_id` was silently dropped when that panel lived on a hidden tab. Most visibly, a shell on a hidden tab that emitted a cursor-position query (DSR 6n on SIGWINCH — fish does this) waited out its full ~10s timeout for the reply that never came, freezing visible input echo on that tab. The previous commit's tab-bar resize made this very easy to hit because it sends SIGWINCH to the old tab right before the new tab is activated. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> (cherry picked from commit 9004810)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContextManager::get_by_route_idonly searched the active tab's grid, so anyRioEventtargeting a specificroute_idwas silently dropped when that panellived on a hidden tab.
Details
Most visibly, a shell on a hidden tab that emitted a cursor-position query
(DSR 6n on SIGWINCH — fish does this) waited out its full ~10s timeout for a
reply that never came, freezing visible input echo on that tab. The tab-bar
resize on tab switch makes this easy to hit because it sends SIGWINCH to the old
tab right before the new tab is activated.
get_by_route_idnow searches alltabs' grids.
Testing
cargo test -p rioterm; manual: open a second tab from fish on the first, switchtabs, confirm input echo on the now-hidden tab is not frozen.
🤖 Generated with Claude Code