[SOAR-20191] Okta plugin improvement #3621
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
… Expire Password, and added a new Reset Password action
lcwiklinski-r7
force-pushed
the
SOAR-20191-Okta-plugin-improvement
branch
from
e94025c to
ec7c95f
Compare
| provider that allows companies to integrate their central user account system with | ||
| a wide variety of other applications and services' | ||
| version: 4.2.16 | ||
| version: 5.0.0 |
There was a problem hiding this comment.
Wonder if this should be 5.0.0 or 4.3.0 😃
There was a problem hiding this comment.
I think the validator forced me to push it to 5.0.0
There was a problem hiding this comment.
Yeah I think because the action schema has changed it's treated as a breaking change
|
|
||
| #### Expire Password | ||
|
|
||
| This action is used to this action expires the password for Okta user and transitions user status to PASSWORD_EXPIRED, |
There was a problem hiding this comment.
I think this wording needs updated
| This action is used to this action expires the password for Okta user and transitions user status to PASSWORD_EXPIRED, | |
| This action is used to expire the password for Okta user and transitions user status to PASSWORD_EXPIRED, |
|
|
||
| This action is used to this action resets password for Okta user and transitions user status to PASSWORD_EXPIRED, so | ||
| that the user is required to change their password at their next login | ||
| This action is used to this action resets the password for an Okta user using a one-time token (OTT), transitions the |
There was a problem hiding this comment.
Same here, I think the first portion gets generated so it's just doubled here.
| provider that allows companies to integrate their central user account system with | ||
| a wide variety of other applications and services' | ||
| version: 4.2.16 | ||
| version: 5.0.0 |
There was a problem hiding this comment.
Yeah I think because the action schema has changed it's treated as a breaking change
| validate(actual, self.action.output.schema) | ||
| self.assertEqual(actual, expected) | ||
|
|
||
| @parameterized.expand( |
There was a problem hiding this comment.
minor but could just set these without parameterized?
5 participants
https://rapid7.atlassian.net/browse/SOAR-20191
I was able to run both manual tests and tests in InsightConnect successfully.
reset password (old)toexpire password. It behaves the same as before - for example, it generates a temporary password. The existing unit tests also pass successfully. However, since the responses are mocked, I had to verify this manually as well.reset passwordaction, I tested two scenarios: one where Okta sends a reset password email to the user, and another where no email is sent - in that case, the response includes a password reset link. The link works correctly and behaves the same as the one sent via email. Unfortunately, I wasn't able to test therevoke sessionsfunctionality. It seems that our Okta instance has expired, so I can't log in to the dashboard; however, the API communication still works.