Skip to content

Conversation

@bcoles
Copy link
Contributor

@bcoles bcoles commented May 15, 2025

Most violations resolved with rubocop -A, except notes.

Also fixes a bug in modules/auxiliary/admin/http/typo3_sa_2009_002.rb:

-    if (file && ((file.message = 'OK')))
+    if file && file.message == 'OK'

Also removes the LFILE option from modules/auxiliary/admin/http/typo3_sa_2009_002.rb, opting to use store_loot instead of the dangerous open() method.

@bcoles bcoles added the code quality Improving code quality label May 15, 2025
@bcoles bcoles force-pushed the rubocop-modules-auxiliary-admin-http branch from e2d56eb to 6ee7d56 Compare May 15, 2025 15:17
@jheysel-r7 jheysel-r7 self-assigned this May 16, 2025
@jheysel-r7 jheysel-r7 merged commit 87c09ac into rapid7:master May 20, 2025
18 checks passed
@bcoles bcoles deleted the rubocop-modules-auxiliary-admin-http branch May 20, 2025 16:39
@jheysel-r7 jheysel-r7 added the rn-no-release-notes no release notes label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Improving code quality rn-no-release-notes no release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants