Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the debug logging behaviour in C Meterp on Windows. When
MeterpreterDebugBuild
was set totrue
, but noMeterpreterDebugLogging
value was set, the call toinit_logging
would fail. A bug existed in the handling of this. Thelog_to_file
method expected the global valuehFile
to beNULL
when there was no logging; however CreateFileW returnsINVALID_HANDLE_VALUE
. As a result, all future calls todprintf
tried to write to an invalid file handle.This was creating issues when
GetLastError()
was called afterdprintf
- the last error value was polluted. One way of reproducing this is to run theexecute_dotnet_assembly
module (misdiagnosed in #746).MeterpreterDebugBuild=true
will fail (the handle is invalid
).MeterpreterDebugBuild=true
and alsoMeterpreterDebugLogging
set to a valid value should succeed.This resolves the issue by correctly setting
hFile
.There's probably more work to be done to make sure that any GetLastError is called before any
dprintf
, since theoretically it is possible for that to changeGetLastError
(e.g. failed file write).