Skip to content

Ruby 2.4 Upgrades #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgreen-r7 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ruby 2.4 Upgrades #302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f79d3e2
Updated for Ruby 2.4 Support
twosevenzero Sep 29, 2017
6f29617
Merge pull request #301 from twosevenzero/update-rexlite-ruby24
sgreen-r7 Oct 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/nexpose/rexlite/mime/header.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def to_s
end

def find(idx)
if (idx.class == ::Fixnum)
if idx.kind_of?(Integer)
Copy link

@houndci-bot houndci-bot Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer Object#is_a? over Object#kind_of?.

return self.headers[idx]
else
self.headers.each do |pair|
Expand All @@ -59,7 +59,7 @@ def add(var, val)
end

def remove(idx)
if (idx.class == ::Fixnum)
if idx.kind_of?(Integer)
Copy link

@houndci-bot houndci-bot Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer Object#is_a? over Object#kind_of?.

self.headers.delete_at(idx)
else
self.headers.each_index do |i|
Expand Down