Add OS CPE to Array Networks ArrayOS AG fingerprint#661
Add OS CPE to Array Networks ArrayOS AG fingerprint#661mpandey-r7 wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the fingerprinting capabilities for Array Networks ArrayOS AG SSL VPN devices by adding comprehensive OS CPE information to the SSH banner fingerprint. This update is related to CVE-2025-66644 tracking and improves device identification accuracy.
Changes:
- Added OS CPE identifier and additional metadata fields to the ArrayOS SSH banner fingerprint
- Sorted and renumbered all identifier files (service_product.txt, service_family.txt, os_product.txt, os_family.txt, device.txt) to include previously unnumbered entries
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| xml/ssh_banners.xml | Enhanced ArrayOS fingerprint with service, OS, and hardware parameters including CPE identifier |
| identifiers/service_product.txt | Added "ArrayOS" entry and sorted all entries with proper line numbering |
| identifiers/service_family.txt | Added "ArrayOS" entry and sorted all entries with proper line numbering |
| identifiers/os_product.txt | Added "ArrayOS AG" entry and sorted all entries with proper line numbering |
| identifiers/os_family.txt | Added "ArrayOS" entry and sorted all entries with proper line numbering |
| identifiers/device.txt | Added "SSL VPN" entry and sorted all entries with proper line numbering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <param pos="0" name="os.product" value="ArrayOS AG"/> | ||
| <param pos="0" name="os.family" value="ArrayOS"/> | ||
| <param pos="0" name="os.device" value="SSL VPN"/> | ||
| <param pos="0" name="os.cpe23" value="cpe:/o:arraynetworks:arrayos_ag:-"/> |
There was a problem hiding this comment.
The PR description references "CVE-2025-66644" but this CVE ID appears to have an invalid format. Standard CVE IDs follow the pattern CVE-YYYY-NNNNN where NNNNN is typically a 4 or 5 digit number (or more for recent years with higher volume). The number "66644" is a 5-digit number which is valid, but this should be verified as a legitimate CVE ID. If this is a typo and should be CVE-2024-66644 or a different CVE, it should be corrected in the PR description to ensure proper tracking and documentation.
Description
A detailed description of your changes.
-Add OS CPE to Array Networks ArrayOS AG fingerprint for CVE-2025-66644
-sorted the identifiers and added the tag for checks
Motivation and Context
Explanation of why these changes are being proposed, including any links to other relevant issues or pull requests.
How Has This Been Tested?
A clear and concise description of your changes were tested.
Types of changes
Checklist: