[5.x] Fix first test case causing error in setStore #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
For an example of where this currently goes wrong, see here: https://github.com/rapidez/core/actions/runs/19764407177/job/56633633635?pr=1076 In this case it's the only error left in the phpunit tests. Once this is merged, all of the tests will work on that PR (theoretically). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The very first test case breaks because something causes the DB transaction for setting the current store to throw an error. In this PR I tried multiple things until it worked---turns out that
DB::reconnect()was necessary after the database dump because the existing connection had broken.Ref: RAP-1656