Skip to content

Uniform review model naming #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
royduin merged 1 commit into from
Nov 28, 2025
Merged

Uniform review model naming #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 21 additions & 22 deletions config/rapidez/models.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,26 +30,25 @@
'product_option_type_title' => Rapidez\Core\Models\ProductOptionTypeTitle::class,
'product_option_type_value' => Rapidez\Core\Models\ProductOptionTypeValue::class,
'product_price' => Rapidez\Core\Models\ProductPrice::class,
// TODO: the naming is mixed..
'product_review' => Rapidez\Core\Models\Review::class,
'product_review_summary' => Rapidez\Core\Models\ProductReviewSummary::class,
'product_stock' => Rapidez\Core\Models\ProductStock::class,
'product_super_link' => Rapidez\Core\Models\ProductSuperLink::class,
'product_tier_price' => Rapidez\Core\Models\ProductTierPrice::class,
'product_view' => Rapidez\Core\Models\ProductView::class,
'quote' => Rapidez\Core\Models\Quote::class,
'quote_id_mask' => Rapidez\Core\Models\QuoteIdMask::class,
'quote_item' => Rapidez\Core\Models\QuoteItem::class,
'quote_item_option' => Rapidez\Core\Models\QuoteItemOption::class,
'report_event' => Rapidez\Core\Models\ReportEvent::class,
'rewrite' => Rapidez\Core\Models\Rewrite::class,
'sales_order' => Rapidez\Core\Models\SalesOrder::class,
'sales_order_address' => Rapidez\Core\Models\SalesOrderAddress::class,
'sales_order_item' => Rapidez\Core\Models\SalesOrderItem::class,
'sales_order_payment' => Rapidez\Core\Models\SalesOrderPayment::class,
'search_query' => Rapidez\Core\Models\SearchQuery::class,
'search_synonym' => Rapidez\Core\Models\SearchSynonym::class,
'store' => Rapidez\Core\Models\Store::class,
'super_attribute' => Rapidez\Core\Models\SuperAttribute::class,
'widget' => Rapidez\Core\Models\Widget::class,
'product_stock' => Rapidez\Core\Models\ProductStock::class,
'product_super_link' => Rapidez\Core\Models\ProductSuperLink::class,
'product_tier_price' => Rapidez\Core\Models\ProductTierPrice::class,
'product_view' => Rapidez\Core\Models\ProductView::class,
'quote' => Rapidez\Core\Models\Quote::class,
'quote_id_mask' => Rapidez\Core\Models\QuoteIdMask::class,
'quote_item' => Rapidez\Core\Models\QuoteItem::class,
'quote_item_option' => Rapidez\Core\Models\QuoteItemOption::class,
'report_event' => Rapidez\Core\Models\ReportEvent::class,
'review' => Rapidez\Core\Models\Review::class,
'review_summary' => Rapidez\Core\Models\ReviewSummary::class,
'rewrite' => Rapidez\Core\Models\Rewrite::class,
'sales_order' => Rapidez\Core\Models\SalesOrder::class,
'sales_order_address' => Rapidez\Core\Models\SalesOrderAddress::class,
'sales_order_item' => Rapidez\Core\Models\SalesOrderItem::class,
'sales_order_payment' => Rapidez\Core\Models\SalesOrderPayment::class,
'search_query' => Rapidez\Core\Models\SearchQuery::class,
'search_synonym' => Rapidez\Core\Models\SearchSynonym::class,
'store' => Rapidez\Core\Models\Store::class,
'super_attribute' => Rapidez\Core\Models\SuperAttribute::class,
'widget' => Rapidez\Core\Models\Widget::class,
];
4 changes: 2 additions & 2 deletions src/Models/Product.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,15 +193,15 @@ public function options(): HasMany
public function reviewSummary(): HasOne
{
return $this->hasOne(
config('rapidez.models.product_review_summary'),
config('rapidez.models.review_summary', ReviewSummary::class),
'entity_pk_value'
);
}

public function reviews(): BelongsToMany
{
return $this->belongsToMany(
config('rapidez.models.product_review', Review::class), 'review',
config('rapidez.models.review', Review::class), 'review',
'entity_pk_value', 'review_id',
'entity_id', 'review_id',
)->where('review.entity_id', Review::REVIEW_ENTITY_PRODUCT);
Expand Down
2 changes: 1 addition & 1 deletion src/Models/ProductReviewSummary.php → src/Models/ReviewSummary.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Relations\BelongsTo;

class ProductReviewSummary extends Model
class ReviewSummary extends Model
{
protected $table = 'review_entity_summary';

Expand Down
Loading