Customer group pricing in the autocomplete #1106
Conversation
There was a problem hiding this comment.
Does it make sense to put these here? Given that we're not really using Vue filters anymore (as they don't exist anymore in Vue3) this is starting to look more like a general helpers.js to me. Might be worth renaming the file now that we're still in pre-release territory.
There was a problem hiding this comment.
My suggestion would then be helpers.js
There was a problem hiding this comment.
I created a follow up for this with ref: RAP-1703
| </div> | ||
| <div class="text-sm text font-sans font-bold"> | ||
| @{{ window.price(item.special_price || item.price) }} | ||
| @{{ window.price(window.productSpecialPrice(item) || window.productPrice(item)) }} |
There was a problem hiding this comment.
Is this still the best way to go here now that we're adding helper functions? For example, could we consider turning this into something like:
<div v-if="window.originalPrice(item)" class="line-through">
@{{ window.originalPrice(item) }}
</div>
<div class="font-bold">
@{{ window.lowestPrice(item) }}
</div>(there's probably better ways to name these, this is just an example)
Or should we stick to how it's always been to avoid hiding away functionality behind unnecessary helper functions?
There was a problem hiding this comment.
I can imagine we don't need the formatting all the time, that's why currently the double wrapping is used. We could introduce more helpers like productSpecialPrice and productSpecialPriceFormatted?
There was a problem hiding this comment.
Ah, I should have included the price helper here still. I was talking about doing away with just having price and specialPrice and instead having specific functions for originalPrice and lowestPrice. It's probably wholly unnecessary, but something I thought was worth considering 🙂
|
Please review @indykoning 😇 |
Follow up on: #1074, extracted some logic to helpers so this can be used more widely; mostly useful for places where products prices are rendered without the
<add-to-cart>component; like the autocomplete.Ref: RAP-1699