Wait max for 1s for config to load before init

[indykoning]

Added a wait for config to be available, in case of issues a max of 1s is used

[Jade-GG]

1. Waiting for 50ms a total of 20 times doesn't feel like the cleanest approach. Would it be cleaner to listen to an event, e.g. by putting an onload on the script tag, or even fire a custom event inside of the js file by adding to config.blade.php? Could even also set a window variable like window.configLoaded so you don't have to specifically check for config.store.

2. Should we have some sort of basic fallback data in case the config doesn't load? Perhaps at least making the notify function work, as that seems to be the most common error.

[indykoning]

1. Waiting for 50ms a total of 20 times doesn't feel like the cleanest approach. Would it be cleaner to listen to an event, e.g. by putting an onload on the script tag, or even fire a custom event inside of the js file by adding to config.blade.php? Could even also set a window variable like window.configLoaded so you don't have to specifically check for config.store.

We could fire a custom event from inside the JS file and await for that if config is missing, though i am in favor of still keeping some kind of timeout to prevent Vue from booting at all if config cannot load for whatever reason.

2. Should we have some sort of basic fallback data in case the config doesn't load? Perhaps at least making the notify function work, as that seems to be the most common error.

While some fallback data would be nice the biggest issues are within templates (e.g. graphql queries) which aren't reactive, thus you will always be stuck with the fallback values.
The Notify function does now work, it is dependent on a Vue component. By extension Vue loading, which we check now.

---

A future enhancement could be utilising a Store for the notifications, since (with turbolinks) it survives page navigations which we currently use different workarounds for.

[royduin]

Follow-up: RAP-1713