[5.x] Add unit tests for product tier prices #1120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royduin
approved these changes
Dec 11, 2025
Member
royduin
left a comment
royduin
left a comment
There was a problem hiding this comment.
Looking good to me. Just to clarify, those methods are just "some helpers" in case we need to show the tierprice somewhere? We're not actually showing it currently anywhere? Should we create follow-up for that? I think Magento will render something on a product page when it's configured?
Member
|
Follow-up: RAP-1712 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements simple unit tests for tier prices. I've also modified the functionality of the
->getPrice(...)function to take thepriceorspecialPricein case they're lower (or return null if they're all null, but this should probably never happen?)ref: RAP-1693