[2.x] Make sure you actually log in in the checkout #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordythevulder
approved these changes
Oct 31, 2024
Member
|
I'd like to know if v3 also needs a fix for this |
indykoning
approved these changes
Oct 31, 2024
Collaborator
Author
From what I can see, the form will still validate incorrectly on v3: https://github.com/rapidez/core/blob/master/resources/views/checkout/steps/login.blade.php So v3 will likely also need a fix unless I'm missing something wrapped around it that validates the login credentials. |
Member
|
Could you arrange that? |
Collaborator
Author
#626 😇 |
Member
|
Any info? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, you could just type in any random password in the password box and it would validate without the need to log in, allowing people to actually try placing an order on an existing account without logging in.
This fixes that bug. I'm not sure if this is also a thing in 3.x as that checkout works quite differently, so I haven't made a PR for that.