Skip to content

Conversation

@royduin
Copy link
Member

@royduin royduin commented Oct 25, 2024

This controller invokes other controllers, but middlewares registered there in the constructor do not work. Not sure yet how Laravel handles this so with this we're checking middlewares of "child controllers" en register them again.

  • Not sure it it's fully compatible with everything; is uses always a controller for example? Otherwise this will break
  • The middlewares of "child controllers" get registered on all fallback routes, this should be scoped to the specific child

@indykoning
Copy link
Member

Unfortunately it can also be an anonymous function. We should check for that
https://docs.rapidez.io/3.x/package-development.html#fallback-routing

@royduin
Copy link
Member Author

royduin commented Nov 20, 2024

2.x #643
3.x #617

@royduin royduin closed this Nov 20, 2024
@royduin royduin deleted the use-fallback-middlewares branch November 20, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants