[REVIEW] Changes to clean to increase speed #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randerzander
suggested changes
Sep 9, 2019
Contributor
randerzander
left a comment
randerzander
left a comment
There was a problem hiding this comment.
Thanks for making the performance improvements, @Nanthini10, but I think you included some changes we don't want to include/change.
Can you undo the unrelated changes, please?
randerzander
suggested changes
Sep 11, 2019
Contributor
randerzander
left a comment
randerzander
left a comment
There was a problem hiding this comment.
A few minor requests.
I'll take an action to go run this on Dataproc again after this PR merges.
| "output_type": "stream", | ||
| "text": [ | ||
| "CPU times: user 34.8 s, sys: 5.18 s, total: 40 s\n", | ||
| "Wall time: 16min 3s\n" |
Contributor
There was a problem hiding this comment.
This looks longer than expected. I'll need to run this again on Dataproc to confirm the current expected runtime.
Co-Authored-By: Randy Gelhausen <[email protected]>
Co-Authored-By: Randy Gelhausen <[email protected]>
Contributor
|
@randerzander did we get to where we wanted to be on this notebook? |
This reverts commit fad594b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made to NYCE2E-Taxi.ipynb to increase the
cleanfunction speed.