Skip to content

Implement BIT_COUNT unary operation #18589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
May 13, 2025
Merged

Implement BIT_COUNT unary operation #18589

merged 26 commits into from
May 13, 2025

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Apr 28, 2025

This implements bitwise count (BIT_COUNT) unary operation for counting the number of set bits in the given integer numbers.

Partially contributes to #18552.

ttnghia added 5 commits April 28, 2025 14:29
@ttnghia
Implement BIT_COUNT unary op
48752a8 
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia
Complete implementation
da8bb20 
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia
Update Java code
9b2cec0 
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia
Revert changes to BIT_INVERT
6882428 
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia
Misc
529e436 
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia ttnghia added feature request New feature or request 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Apr 28, 2025
@ttnghia ttnghia self-assigned this Apr 28, 2025
@ttnghia ttnghia requested review from a team as code owners April 28, 2025 23:00
@ttnghia ttnghia requested review from bdice and vuule April 28, 2025 23:00
@ttnghia ttnghia added this to libcudf Apr 28, 2025
@github-actions github-actions bot added the Java Affects Java cuDF API. label Apr 28, 2025
vuule
vuule reviewed Apr 29, 2025
View reviewed changes
ttnghia added 2 commits April 28, 2025 21:06
@ttnghia
Use __popc and __popcll
61c2ed5 
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia
Simplify implementation
2496aae 
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia ttnghia mentioned this pull request Apr 29, 2025
Merged
@GregoryKimball GregoryKimball moved this to Burndown in libcudf May 5, 2025
razajafri
razajafri approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@razajafri razajafri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for Java

razajafri
razajafri reviewed May 9, 2025
View reviewed changes
@ttnghia
Update copyright year
31a4ab0 
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia ttnghia added breaking Breaking change and removed non-breaking Non-breaking change labels May 12, 2025
vuule
vuule approved these changes May 12, 2025
View reviewed changes
ttnghia added 3 commits May 12, 2025 16:02
@ttnghia
Shorten tests
bf82c66 
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia
Fix empty inputt case
f2b640c 
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia
Add BIT_COUNT
bbe5b36 
Signed-off-by: Nghia Truong <[email protected]>
@ttnghia ttnghia requested a review from a team as a code owner May 12, 2025 23:28
@ttnghia ttnghia requested review from wence- and galipremsagar May 12, 2025 23:28
@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels May 12, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python May 12, 2025
@ttnghia
Copy link
Contributor Author

ttnghia commented May 12, 2025

I've just added the BIT_COUNT enum into python code so the operator list in python mirrors exactly the enum in libcudf. Just to have a peace of mind.

Matt711
Matt711 approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, approving the python change! I also noticed the unary tests in pylibcudf are lacking, but I'll leave that as a follow-up for myself.

@ttnghia
Copy link
Contributor Author

ttnghia commented May 13, 2025

/merge

@rapids-bot rapids-bot bot merged commit 35d5839 into rapidsai:branch-25.06 May 13, 2025
127 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python May 13, 2025
@ttnghia ttnghia deleted the unary_bitwise_ops branch May 13, 2025 17:35
@vuule vuule moved this from Burndown to Landed in libcudf May 13, 2025
ttnghia added a commit to NVIDIA/spark-rapids that referenced this pull request May 19, 2025
@ttnghia @winningsix
Support bit_count SQL function (#12606)
54f2f97 
This adds support for `bit_count` SQL function.

Depends on:
 * rapidsai/cudf#18589

Closes #12571.

---------

Signed-off-by: Nghia Truong <[email protected]>
Co-authored-by: Ferdinand Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@res-life res-life res-life left review comments

@razajafri razajafri razajafri approved these changes

@PointKernel PointKernel PointKernel left review comments

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@mroeschke mroeschke mroeschke approved these changes

@vuule vuule vuule approved these changes

@lamarrr lamarrr lamarrr approved these changes

@Matt711 Matt711 Matt711 approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@ttnghia ttnghia

Labels
3 - Ready for Review Ready for review by team breaking Breaking change feature request New feature or request Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
cuDF Python
Status: Done
libcudf
Status: Landed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ttnghia @vuule @res-life @razajafri @mroeschke @PointKernel @mhaseeb123 @lamarrr @Matt711