-
Notifications
You must be signed in to change notification settings - Fork 948
Locally import pyarrow.dataset and fsspec for import cudf
performance
#18663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locally import pyarrow.dataset and fsspec for import cudf
performance
#18663
Conversation
This reverts commit e00cfe6.
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
# fails without this pyarrow.dataset import | ||
# I suspect it relates to pyarrow's pandas-shim that gets imported | ||
# with this module https://github.com/rapidsai/cudf/issues/14521#issue-2015198786 | ||
import pyarrow.dataset as ds # noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that @bdice is mostly out this week so if you want to get him to take a look you will either need to wait a while or ping him directly and see if he has a few moments. If nothing is too controversial you could also merge and do a follow-up next week when he's back if he has additional requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as-is. I don't have time to dig deep into the root cause for this but the comment is helpful for now.
# fails without this pyarrow.dataset import | ||
# I suspect it relates to pyarrow's pandas-shim that gets imported | ||
# with this module https://github.com/rapidsai/cudf/issues/14521#issue-2015198786 | ||
import pyarrow.dataset as ds # noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as-is. I don't have time to dig deep into the root cause for this but the comment is helpful for now.
/merge |
Description
These are some low hanging fruit imports that we can make lazy to marginally improve import performance xref #627
Pyinstrument of
import cudf
beforePyinstrument of
import cudf
afterChecklist