Reuse libcudf dependencies for Java JNI build when they are available
#18682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
added
feature request
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
This reverts commit d898a72.
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
vyasr
approved these changes
May 8, 2025
gerashegalov
approved these changes
May 13, 2025
|
/merge |
ttnghia
added a commit
to NVIDIA/spark-rapids-jni
that referenced
this pull request
May 14, 2025
This modifies CMake build to search for dependency packages that have been installed alongside with libcudf. Having this, we can avoid pulling dependencies multiple times when they are already available. There are also a few minor cleanup are performed in this work. Depends on: * rapidsai/cudf#18682 --------- Signed-off-by: Nghia Truong <[email protected]>
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
May 19, 2025
fix #18851, as a follow-up of #18682. Verified with internal pipeline. Authors: - Peixin (https://github.com/pxLi) - Nghia Truong (https://github.com/ttnghia) Approvers: - Tim Liu (https://github.com/NvTimLiu) URL: #18852
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies CMake build for Java JNI, adding the environment variable
CUDF_INSTALL_DIRthat allows to specify the path of packages that have been installed alongside with libcudf. Having this, we can avoid pulling dependencies multiple times when they are already available.Closes #18656.