Skip to content

Remove redundant xfails in cuml integration tests #18699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented May 7, 2025

Description

Follow up to https://github.com/rapidsai/cudf/pull/18561/files#r2056719715

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented May 7, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels May 7, 2025
@Matt711 Matt711 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 7, 2025
@Matt711
Copy link
Contributor Author

Matt711 commented May 7, 2025

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented May 7, 2025

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented May 8, 2025

/ok to test

@vyasr
Copy link
Contributor

vyasr commented May 19, 2025

@Matt711 do we still want to get this in?

@Matt711
Copy link
Contributor Author

Matt711 commented May 19, 2025

@Matt711 do we still want to get this in?

Yes, once I get #18870 in. I'll rerun CI and open this PR up for review

@Matt711
Copy link
Contributor Author

Matt711 commented May 19, 2025

/ok to test

@GPUtester GPUtester moved this to In Progress in cuDF Python May 19, 2025
@Matt711 Matt711 marked this pull request as ready for review May 19, 2025 20:07
@Matt711 Matt711 requested a review from a team as a code owner May 19, 2025 20:07
@Matt711 Matt711 requested review from vyasr and rjzamora May 19, 2025 20:07
@vyasr
Copy link
Contributor

vyasr commented May 19, 2025

/merge

@rapids-bot rapids-bot bot merged commit 26227bd into rapidsai:branch-25.06 May 19, 2025
123 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf.pandas Issues specific to cudf.pandas improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants