Add Python tests for different compression implementations #18710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
vuule
added
tests
vuule
commented
May 7, 2025
| assert_frame_equal(cudf.from_pandas(expect), got) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("compression", ["LZ4", "SNAPPY", "ZLIB", "ZSTD"]) |
Contributor
Author
There was a problem hiding this comment.
could not include brotli, seems like pandas does not support it on the writer side.
mroeschke
reviewed
May 7, 2025
python/cudf/cudf/tests/test_avro_reader_fastavro_integration.py
Outdated
Show resolved
Hide resolved
mroeschke
approved these changes
May 13, 2025
Contributor
Author
|
/merge |
Contributor
Author
|
issue #18445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests that are parameterized on the compression codec and the implementation (nvCOMP, internal kernel, host) to ensure all available implementations are tested for all supported codecs.
These tests cover codecs that cannot be covered by C++ tests because we don't have writer support and thus need to use another library to generate input.
Checklist