fix(rattler): add librmm to host for libcudf to fix overlinking error
#18754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
added
improvement
3 tasks
5 tasks
Contributor
|
Blocked on rapidsai/rmm#1913. We'll use this PR to validate that upstream rmm fixes are sufficient as well. |
vyasr
approved these changes
May 12, 2025
Contributor
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need
librmmfor buildinglibcudfandlibrmmis available in the cache build stage. However the overlinking checks happen on a per-output basis and now thatlibrmmisn't header-only,rattleris detecting a missing link.This adds the
librmmentry to thehostsection of the appropriate outputs.xref rapidsai/build-planning#175
Checklist