Raise on unsupported unstack cases #20463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
galipremsagar
requested changes
Nov 3, 2025
|
Some more XPASS'ing tests (good). But some of the cuDF classic tests are failing because of the new raise I'm adding in this PR. I think we should only raise in Pandas compatibility mode. Not ideal, but since we're planning to rewrite the pivot/unstack code in cuDF for performance anyway, I think it's okay. |
Yup, Let's do that and open an issue to re-write / GPU accelerate this API so that we don't lose track of it. |
galipremsagar
approved these changes
Nov 3, 2025
|
Thanks @Matt711 ! |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #18659
Closes #20446
Checklist