Skip to content

Fix GPU acceleration bug in decimal type-cast #20471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 4, 2025
Merged

Fix GPU acceleration bug in decimal type-cast #20471

merged 6 commits into from
Nov 4, 2025
+13 −1

Conversation

@galipremsagar
Copy link
Contributor

Description

Closes: #20470

This PR:

  • Remove CPU fallback in typecasting of know decimal types.
  • Raises a valid error when arbitrary decimal values are used in binops for decimal extension types.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar self-assigned this Nov 3, 2025
@galipremsagar galipremsagar requested a review from a team as a code owner November 3, 2025 20:07
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Nov 3, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Nov 3, 2025
bdice
bdice approved these changes Nov 3, 2025
View reviewed changes
@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Nov 3, 2025
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Nov 3, 2025
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit cab7913 into rapidsai:main Nov 4, 2025
135 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdice bdice bdice approved these changes

@TomAugspurger TomAugspurger Awaiting requested review from TomAugspurger TomAugspurger is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working cudf.pandas Issues specific to cudf.pandas non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

cuDF Python
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Type converting a decimal to arrow-decial type in cudf.pandas is falling back to CPU

2 participants

@galipremsagar @bdice