remove_multi_edges bug fix. #4961
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seunghwak
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove_multi_edgesfunctions takeskeep_min_edge_value.This is set to true when removing multi-edges in a symmetric edge list (which will be used to create an undirected graph) to ensure that the edge list remain symmetric (including edge values).
The existing implementation doesn't work properly if # edge properties > 1.
The existing implementation sorts (src, dst, edge index) and keeps the edge with the minimum index among the multi-edges between src & dst. This doesn't guarantee that the same (src, dst, edge value) will be selected in both directions.
This PR fixes this bug.