Forward-merge release/26.10 into main - #5665
Merged
Merged
Conversation
As of NVIDIA/cuvs#2565 (I think), `libcuvs.so` requires `libkvikio.so` at runtime. ```shell mkdir -p ./delete-me pip download \ -d ./delete-me \ --no-deps \ --index-url https://pypi.anaconda.org/rapidsai-wheels-nightly/simple/ \ 'libcuvs-cu13>=26.10.0a0' cd ./delete-me unzip ./libcuvs*.whl ``` ```console $ ldd libcuvs/lib64/libcuvs.so ... libkvikio.so => not found ... ``` `auditwheel repair` sees that dependency when it resolves `libcugraph.so`'s dependency on `libcuvs.so`, and so CI is failing here like this: > ValueError: Cannot repair wheel, because required library "libkvikio.so" could not be located ([build link](https://github.com/rapidsai/cugraph/actions/runs/34483969788/job/102894257002)) This fixes that by excluding `libkvikio.so` from `auditwheel repair`. This is safe to do because `libcuvs-cu13` has a runtime dependency on `libkvikio-cu13` to provide that. ## Notes for Reviewers A similar change was needed in `cuml`: NVIDIA/cuml#8604 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Bradley Dice (https://github.com/bdice) URL: #5663
Contributor
Author
|
SUCCESS - forward-merge complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/26.10 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.