Skip to content

Add flag to enable cudf.pandas with CLI #6364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: branch-25.04
Choose a base branch
from

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Feb 25, 2025

Adds flag to enable cudf.pandas to experimental CLI UX

@dantegd dantegd added feature request New feature or request non-breaking Non-breaking change cuml-cpu labels Feb 25, 2025
@dantegd dantegd requested review from a team as code owners February 25, 2025 04:52
@github-actions github-actions bot added Cython / Python Cython or Python issue ci labels Feb 25, 2025
dantegd added a commit to dantegd/cuml that referenced this pull request Feb 25, 2025
# Support invoking run_cuml_singlegpu_pytests.sh outside the script directory
cd "$(dirname "$(realpath "${BASH_SOURCE[0]}")")"/../python/cuml/cuml/tests

python -m pytest -p cudf.pandas -p cuml.experimental.accel --cache-clear "$@" experimental/accel/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the cuml.accel tests in run_cuml_singlegpu_accel_pytests.sh we cd into the experimental/accel directory. Can we keep it consistent? Not sure but maybe it effects the paths we see in the logs?

Copy link
Member

@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now this is good, but we should look at how we do CI and testing more holistically.

@dantegd
Copy link
Member Author

dantegd commented Feb 25, 2025

/merge

dantegd added a commit to dantegd/cuml that referenced this pull request Feb 26, 2025
raydouglass pushed a commit that referenced this pull request Feb 28, 2025
PRs being backported: 

- [x] #6234
- [x] #6306
- [x] #6320
- [x] #6319
- [x] #6327
- [x] #6333
- [x] #6142 
- [x] #6223
- [x] #6235
- [x] #6317 
- [x] #6331
- [x] #6326
- [x] #6332
- [x] #6347
- [x] #6348
- [x] #6337
- [x] #6355
- [x] #6354
- [x] #6322
- [x] #6353
- [x] #6359
- [x] #6364
- [x] #6363
- [x] [FIL BATCH_TREE_REORG fix for SM90, 100 and
120](a3e419a)

---------

Co-authored-by: William Hicks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci cuml-cpu Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants