-
Notifications
You must be signed in to change notification settings - Fork 569
Port all conda recipes to rattler-build
#6440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
ae89c27
feat(libcuml): port libcuml to rattler-build
gforsyth 0a4555c
fix(libcuml): resolve all overlinking errors
gforsyth a68bed0
refactor(libcuml): remove old conda recipe and scripts
gforsyth b4fa3f4
fix(libcuml): disable binary prefix patching
gforsyth def6cc6
feat(cuml): port cuml recipe to rattler-build
gforsyth 39f854e
feat(cuml-cpu): port cuml-cpu recipe to rattler-build
gforsyth e40fb57
refactor(cuml): remove old conda recipe and scripts
gforsyth 5abc251
refactor(cuml-cpu): remove old conda recipe and scripts
gforsyth 5a4fd8b
refactor(ci): use rattler-build for cpp and python conda ci builds
gforsyth a607378
chore: fix shellcheck error in accel test script
gforsyth 1548b5b
Merge branch 'branch-25.04' into rattler-build
gforsyth e9cbe40
fix(cuml): disable import test
gforsyth 56bf912
refactor(libcuml,cuml): make sccache prefix more granular
gforsyth 2b492cd
fix(cuml-cpu): add missing secrets and env section
gforsyth fa4aa01
prepend `cuda` to part of sccache key prefix
gforsyth 6847b50
Merge branch 'branch-25.04' into rattler-build
gforsyth b105e7b
chore: remove default values from recipe
gforsyth f6c8af7
Merge branch 'branch-25.04' into rattler-build
gforsyth 099c435
fix(libcuml): use `host_version` for host deps
gforsyth 97fc0d0
fix(libcuml): ignore `cudatoolkit` on cuda11
gforsyth 43c5643
Merge branch 'branch-25.04' into rattler-build
gforsyth 01c688b
chore(rattler): improve comment about build cache removal
gforsyth 5005bb0
chore: remove extraneous zero-stats call
gforsyth 6ad24e1
chore(rattler): fix copyright year
gforsyth 9e57403
fix(cuml): skip libarrow gdb file and disable prefix patching
gforsyth 5d1405f
Merge branch 'branch-25.04' into rattler-build
gforsyth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
# Copyright (c) 2025, NVIDIA CORPORATION. | ||
schema_version: 1 | ||
|
||
context: | ||
version: ${{ env.get("RAPIDS_PACKAGE_VERSION") }} | ||
date_string: '${{ env.get("RAPIDS_DATE_STRING") }}' | ||
py_version: ${{ env.get("RAPIDS_PY_VERSION") }} | ||
py_buildstring: ${{ py_version | version_to_buildstring }} | ||
head_rev: ${{ git.head_rev(".")[:8] }} | ||
|
||
package: | ||
name: cuml-cpu | ||
version: ${{ version }} | ||
|
||
source: | ||
path: ../../.. | ||
|
||
build: | ||
string: py${{ py_buildstring }}_${{ date_string }}_${{ head_rev }} | ||
dynamic_linking: | ||
overlinking_behavior: "error" | ||
script: | ||
content: | | ||
./build.sh cuml-cpu -v | ||
secrets: | ||
- AWS_ACCESS_KEY_ID | ||
- AWS_SECRET_ACCESS_KEY | ||
- AWS_SESSION_TOKEN | ||
env: | ||
CMAKE_C_COMPILER_LAUNCHER: ${{ env.get("CMAKE_C_COMPILER_LAUNCHER") }} | ||
CMAKE_CXX_COMPILER_LAUNCHER: ${{ env.get("CMAKE_CXX_COMPILER_LAUNCHER") }} | ||
CMAKE_GENERATOR: ${{ env.get("CMAKE_GENERATOR") }} | ||
SCCACHE_BUCKET: ${{ env.get("SCCACHE_BUCKET") }} | ||
SCCACHE_IDLE_TIMEOUT: ${{ env.get("SCCACHE_IDLE_TIMEOUT") }} | ||
SCCACHE_REGION: ${{ env.get("SCCACHE_REGION") }} | ||
SCCACHE_S3_USE_SSL: ${{ env.get("SCCACHE_S3_USE_SSL") }} | ||
SCCACHE_S3_NO_CREDENTIALS: ${{ env.get("SCCACHE_S3_NO_CREDENTIALS") }} | ||
SCCACHE_S3_KEY_PREFIX: cuml-cpu/${{ env.get("RAPIDS_CONDA_ARCH") }} | ||
|
||
requirements: | ||
build: | ||
- ${{ compiler("c") }} | ||
- ${{ compiler("cxx") }} | ||
- ${{ stdlib("c") }} | ||
- cmake ${{ cmake_version }} | ||
- ninja | ||
host: | ||
- cython >=3.0.0 | ||
- pip | ||
- python =${{ py_version }} | ||
- rapids-build-backend>=0.3.0,<0.4.0.dev0 | ||
- scikit-build-core >=0.10.0 | ||
run: | ||
- numpy >=1.23,<3.0a0 | ||
- python | ||
- pandas | ||
- packaging | ||
- scikit-learn 1.5.* | ||
- hdbscan>=0.8.39,<0.8.40 | ||
- umap-learn=0.5.6 | ||
- nvtx | ||
ignore_run_exports: | ||
by_name: | ||
- cuda-cudart | ||
- cuda-version | ||
- if: cuda_major == "11" | ||
then: cudatoolkit | ||
|
||
tests: | ||
- python: | ||
imports: | ||
- cuml | ||
pip_check: false | ||
|
||
about: | ||
homepage: ${{ load_from_file("python/cuml/pyproject.toml").project.urls.Homepage }} | ||
license: ${{ load_from_file("python/cuml/pyproject.toml").project.license.text }} | ||
summary: cuML-CPU Library |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, haven't reviewed one of these PRs before... why are we opting into experimental stuff from
rattler-build
? What specifically do we need?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main usage of
--experimental
is the pre-build or cache-build option, otherwise we'd have to compile everything for each output. It's been marked experimental for a while, but we're confident it's not going anywhere (I suspect the main reason it's still gated is that upstream may want to change some names around).Wolf and I were discussing how the phrase multiple output cache can cause confusion when paired with
sccache
and compilation caches -- so maybepre-build
would be a better name, but that will require breaking changes to the yaml spec.