Skip to content

Mark XGBoost tests as XFAIL #6515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Mark XGBoost tests as XFAIL #6515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions python/cuml/cuml/tests/experimental/test_filex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ def _build_and_save_xgboost(
)
@pytest.mark.parametrize("n_classes", [2, 5, 25])
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
def test_fil_classification(
train_device,
infer_device,
Expand Down Expand Up @@ -229,6 +230,7 @@ def test_fil_classification(
"max_depth", [unit_param(3), unit_param(7), stress_param(11)]
)
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
def test_fil_regression(
train_device,
infer_device,
Expand Down Expand Up @@ -511,6 +513,7 @@ def small_classifier_and_preds(tmpdir_factory, request):
@pytest.mark.parametrize("infer_device", ("cpu", "gpu"))
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
@pytest.mark.parametrize("precision", ["native", "float32", "float64"])
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
def test_precision_xgboost(
train_device, infer_device, precision, small_classifier_and_preds
):
Expand All @@ -536,6 +539,7 @@ def test_precision_xgboost(
@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
@pytest.mark.parametrize("layout", ["depth_first", "breadth_first", "layered"])
@pytest.mark.parametrize("chunk_size", [2, 4, 8, 16, 32])
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
def test_performance_hyperparameters(
train_device, infer_device, layout, chunk_size, small_classifier_and_preds
):
Expand All @@ -562,6 +566,7 @@ def test_performance_hyperparameters(
@pytest.mark.parametrize("train_device", ("cpu", "gpu"))
@pytest.mark.parametrize("infer_device", ("cpu", "gpu"))
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
def test_output_args(train_device, infer_device, small_classifier_and_preds):
with using_device_type(train_device):
model_path, model_type, X, xgb_preds = small_classifier_and_preds
Expand Down Expand Up @@ -722,6 +727,7 @@ def test_lightgbm(
@pytest.mark.parametrize("n_classes", [2, 5, 25])
@pytest.mark.parametrize("num_boost_round", [10, 100])
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
def test_predict_per_tree(
train_device, infer_device, n_classes, num_boost_round, tmp_path
):
Expand Down Expand Up @@ -783,6 +789,7 @@ def test_predict_per_tree(
@pytest.mark.parametrize("infer_device", ("cpu", "gpu"))
@pytest.mark.parametrize("n_classes", [5, 25])
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
def test_predict_per_tree_with_vector_leaf(
train_device, infer_device, n_classes, tmp_path
):
Expand Down Expand Up @@ -829,6 +836,7 @@ def test_predict_per_tree_with_vector_leaf(
@pytest.mark.parametrize("infer_device", ("cpu", "gpu"))
@pytest.mark.parametrize("n_classes", [2, 5, 25])
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
def test_apply(train_device, infer_device, n_classes, tmp_path):
n_rows = 1000
n_columns = 30
Expand Down
5 changes: 5 additions & 0 deletions python/cuml/cuml/tests/explainer/test_gpu_treeshap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ def count_categorical_split(tl_model):
],
)
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
@pytest.mark.skipif(not has_shap(), reason="need to install shap")
@pytest.mark.skipif(not has_sklearn(), reason="need to install scikit-learn")
def test_xgb_regressor(objective):
Expand Down Expand Up @@ -223,6 +224,7 @@ def test_xgb_regressor(objective):
],
)
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
@pytest.mark.skipif(not has_shap(), reason="need to install shap")
@pytest.mark.skipif(not has_sklearn(), reason="need to install scikit-learn")
def test_xgb_classifier(objective, n_classes):
Expand Down Expand Up @@ -478,6 +480,7 @@ def test_sklearn_rf_classifier(n_classes):


@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
def test_xgb_toy_categorical():
X = pd.DataFrame(
{
Expand Down Expand Up @@ -511,6 +514,7 @@ def test_xgb_toy_categorical():

@pytest.mark.parametrize("n_classes", [2, 3])
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
@pytest.mark.skipif(not has_sklearn(), reason="need to install scikit-learn")
def test_xgb_classifier_with_categorical(n_classes):
n_samples = 100
Expand Down Expand Up @@ -572,6 +576,7 @@ def test_xgb_classifier_with_categorical(n_classes):


@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
@pytest.mark.skipif(not has_sklearn(), reason="need to install scikit-learn")
def test_xgb_regressor_with_categorical():
n_samples = 100
Expand Down
4 changes: 4 additions & 0 deletions python/cuml/cuml/tests/test_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,10 @@ def test_real_algos_runner(algo_name):
):
pytest.xfail()

# TODO(hcho3): Remove once XGBoost works with older drivers
if algo_name == "FIL":
pytest.xfail(reason="xgboost's allocator doesn't work with older drivers")

runner = AccuracyComparisonRunner(
[50], [5], dataset_name="classification", test_fraction=0.20
)
Expand Down
9 changes: 9 additions & 0 deletions python/cuml/cuml/tests/test_fil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ def _build_and_save_xgboost(
)
@pytest.mark.parametrize("n_classes", [2, 5, 25])
@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
@pytest.mark.filterwarnings("ignore::FutureWarning")
def test_fil_classification(
n_rows, n_columns, num_rounds, n_classes, tmp_path
Expand Down Expand Up @@ -205,6 +206,7 @@ def test_fil_classification(
"max_depth", [unit_param(3), unit_param(7), stress_param(11)]
)
@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
@pytest.mark.filterwarnings("ignore::FutureWarning")
def test_fil_regression(n_rows, n_columns, num_rounds, tmp_path, max_depth):
# settings
Expand Down Expand Up @@ -469,6 +471,7 @@ def small_classifier_and_preds(tmpdir_factory, request):


@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
@pytest.mark.parametrize(
"algo",
[
Expand Down Expand Up @@ -501,6 +504,7 @@ def test_output_algos(algo, small_classifier_and_preds):


@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
@pytest.mark.parametrize("precision", ["native", "float32", "float64"])
@pytest.mark.filterwarnings("ignore::FutureWarning")
def test_precision_xgboost(precision, small_classifier_and_preds):
Expand All @@ -521,6 +525,7 @@ def test_precision_xgboost(precision, small_classifier_and_preds):


@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
@pytest.mark.parametrize(
"storage_type", [False, True, "auto", "dense", "sparse", "sparse8"]
)
Expand All @@ -543,6 +548,7 @@ def test_output_storage_type(storage_type, small_classifier_and_preds):


@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
@pytest.mark.parametrize("storage_type", ["dense", "sparse"])
@pytest.mark.parametrize("blocks_per_sm", [1, 2, 3, 4])
@pytest.mark.filterwarnings("ignore::FutureWarning")
Expand All @@ -567,6 +573,7 @@ def test_output_blocks_per_sm(


@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
@pytest.mark.parametrize("threads_per_tree", [2, 4, 8, 16, 32, 64, 128, 256])
@pytest.mark.filterwarnings("ignore::FutureWarning")
def test_threads_per_tree(threads_per_tree, small_classifier_and_preds):
Expand Down Expand Up @@ -594,6 +601,7 @@ def test_threads_per_tree(threads_per_tree, small_classifier_and_preds):

@pytest.mark.parametrize("output_class", [True, False])
@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
@pytest.mark.filterwarnings("ignore::FutureWarning")
def test_thresholding(output_class, small_classifier_and_preds):
model_path, model_type, X, xgb_preds = small_classifier_and_preds
Expand All @@ -612,6 +620,7 @@ def test_thresholding(output_class, small_classifier_and_preds):


@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
@pytest.mark.filterwarnings("ignore::FutureWarning")
def test_output_args(small_classifier_and_preds):
model_path, model_type, X, xgb_preds = small_classifier_and_preds
Expand Down
Loading