Localise output‑dtype; remove global set_api_output_dtype calls #6561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ofek-Haim
force-pushed
the
fix/output-dtype-local
branch
from
7c204de to
ce9b9da
Compare
|
/ok to test ce9b9da |
|
@Ofek-Haim Thank you very much for the contribution! It looks like CI got tripped on the style checks. Most style issues can be automatically addressed by running the automated pre-commit hooks. Can you see if you can apply those and then push a fix? Let us know if you have any trouble with this, happy to step you through it in more detail. |
|
@Ofek-Haim Do you need help with bringing this branch up-to-date and fixing the style issues? |
|
Hi, I am very happy to join and support the project. I have a busy period
until Wednesday. On Thursday I can come back and finish the CR corrections.
After Wednesday I will have a lot of time to work on the project. Is that
okay?
Thank you very much
Ofek
בתאריך יום ה׳, 1 במאי 2025 ב-21:35 מאת Simon Adorf ***@***.***
…:
*csadorf* left a comment (rapidsai/cuml#6561)
<#6561 (comment)>
@Ofek-Haim <https://github.com/Ofek-Haim> Do you need help with bringing
this branch up-to-date and fixing the style issues?
—
Reply to this email directly, view it on GitHub
<#6561 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHCR4OPX5NEXAQWCVZ6B6A324IWJTAVCNFSM6AAAAAB3QCYVKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBUHE3DCMZTGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
cuml.internals.set_api_output_dtypecalls from:svm/svm_base.pyxneighbors/kneighbors_regressor.pyxexperimental/fil/fil.pyxlegacy/fil/fil.pyxout_dtypelocally and casts once beforereturn.Why
Changing the global output‑dtype inside estimator methods causes
unpredictable side‑effects on subsequent cuML calls.
This PR localises dtype handling, ensuring thread‑/call‑safety.
Fixes
Closes #6412