Add timeout to scikit-learn test suite #6591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrist
added
improvement
|
edit: done |
These sometimes hang, but usually run in < 30 mins. Adding a timeout to catch hung test runs earlier.
gforsyth
approved these changes
Apr 28, 2025
csadorf
approved these changes
Apr 28, 2025
|
/merge |
|
For reference, we experienced more hangs on CUDA 11.8 in recent nightlies that will not be fixed by this PR, but more quickly detected: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These sometimes hang, but usually run in < 30 mins. Adding a timeout to catch hung test runs earlier.