Skip to content

Conversation

@tarang-jain
Copy link
Contributor

libaio is used directly at run time by the diskann_ssd benchmarking wrapper in cuvs-bench-cpu.

- if: linux64
then: mkl =2023
then:
- libaio # Required for diskann_ssd at runtime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is libaio also needed to build the package? Do we need an entry in host for that?

The entry in ignore_run_exports wasn't doing anything because no run exports were being added. Run exports would only be present if libaio was in host to begin with.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its needed to build DiskANN and we are directly linking the wrapper to it here:

NAME DISKANN_MEMORY PATH src/diskann/diskann_benchmark.cpp LINKS diskann::diskann aio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Development

Successfully merging this pull request may close these issues.

3 participants