Skip to content

Revert "FIX: disable warpspeed scan (#2062)"#2074

Open
bdice wants to merge 1 commit into
rapidsai:mainfrom
bdice:enable-warpspeed
Open

Revert "FIX: disable warpspeed scan (#2062)"#2074
bdice wants to merge 1 commit into
rapidsai:mainfrom
bdice:enable-warpspeed

Conversation

@bdice
Copy link
Copy Markdown
Contributor

@bdice bdice commented May 12, 2026

This reverts commit fc3d6c1.

rapidsai/rapids-cmake#1018 updated to a newer CCCL version with a fix for the Warpspeed kernel bugs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7ef3ead3-8055-4586-9f8c-693a1e3345fe

📥 Commits

Reviewing files that changed from the base of the PR and between 90c18a8 and 8fb0a2f.

📒 Files selected for processing (1)
  • cpp/cmake/modules/ConfigureCUDA.cmake
💤 Files with no reviewable changes (1)
  • cpp/cmake/modules/ConfigureCUDA.cmake

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated CUDA build configuration to enable warpspeed scan optimization by default, which may improve performance on supported GPU architectures.

Walkthrough

The PR removes a compiler flag definition (-DCCCL_DISABLE_WARPSPEED_SCAN) from the CUDA CMake configuration module. This 4-line deletion disables the explicit build-time suppression of CCCL warpspeed scan functionality, allowing the feature to be enabled by default during compilation.

Changes

Warpspeed scan compiler flag removal

Layer / File(s) Summary
Remove CCCL_DISABLE_WARPSPEED_SCAN from compiler flags
cpp/cmake/modules/ConfigureCUDA.cmake
The -DCCCL_DISABLE_WARPSPEED_SCAN definition is removed from both CUVS_CXX_FLAGS and CUVS_CUDA_FLAGS, enabling warpspeed scan by default.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • rapidsai/cuvs#2062: Adds the -DCCCL_DISABLE_WARPSPEED_SCAN compiler flag workaround that this PR reverses.

Suggested labels

improvement, non-breaking

Suggested reviewers

  • cjnolet
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: reverting a previous commit that disabled warpspeed scan, which aligns with the CMake module removing the disable compiler definition.
Description check ✅ Passed The description is relevant to the changeset, explaining the rationale for the revert (updated CCCL version with Warpspeed kernel bug fixes) and referencing the specific commit being reverted.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@bdice bdice added bug Something isn't working non-breaking Introduces a non-breaking change labels May 12, 2026
@bdice bdice self-assigned this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant