Skip to content

Inner Product for CAGRA-Q #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: branch-25.06
Choose a base branch
from
Open

Inner Product for CAGRA-Q #458

wants to merge 27 commits into from

Conversation

tarang-jain
Copy link
Contributor

Partially addresses #198 (Cosine still pending for CAGRA and CAGRA-Q).

@github-actions github-actions bot added the cpp label Nov 10, 2024
@tarang-jain tarang-jain added feature request New feature or request non-breaking Introduces a non-breaking change labels Nov 11, 2024
@tarang-jain tarang-jain self-assigned this Nov 11, 2024
@github-actions github-actions bot added the CMake label Nov 12, 2024
achirkin
achirkin requested changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@achirkin achirkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It's nice to see only minimal changes are needed to add a new metric.
There are (as expected) many new files though. Could you please check the binary size doesn't blow up?

cpp/test/neighbors/ann_cagra.cuh Outdated
{false},
{true},
{0.6}); // don't demand high recall without refinement
{0.55}); // don't demand high recall without refinement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please justify, why reducing the recall here? Why is it not a bug in build or search functions?

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 19, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cjnolet
Copy link
Member

cjnolet commented Nov 20, 2024

/ok to test

@tarang-jain tarang-jain changed the base branch from branch-24.12 to branch-25.02 January 10, 2025 07:52
@tarang-jain tarang-jain marked this pull request as ready for review January 10, 2025 11:35
@tarang-jain tarang-jain requested review from a team as code owners January 10, 2025 11:35
@tarang-jain
Copy link
Contributor Author

tarang-jain commented Jan 11, 2025 •
edited
Loading

Binary size comparison (built from source for all CUDA archs):
While this PR does add several new source files due to the multiple new template instantiations, the binary size of the libcuvs objects does not increase significantly and actually sizes remain the same.
Size of libcuvs.so (branch-25.02): 852M
Size of libcuvs.so (Pull Request): 852M
Size of libcuvs_static.a (branch-25.02): 635M
Size of libcuvs_static.a (branch-25.02): 635M

@cjnolet
Copy link
Member

cjnolet commented Jan 15, 2025

/ok to test

@tarang-jain tarang-jain changed the base branch from branch-25.02 to branch-25.04 March 14, 2025 16:53
@tarang-jain tarang-jain requested a review from a team as a code owner March 14, 2025 16:53
@tarang-jain tarang-jain changed the base branch from branch-25.04 to branch-25.06 April 17, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achirkin achirkin achirkin requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@tarang-jain tarang-jain

Labels
CMake cpp feature request New feature or request non-breaking Introduces a non-breaking change Python
Projects
VS/ML/DM Primitives Release Board
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarang-jain @cjnolet @achirkin