Skip to content

Java: Fix for a crash situation when using different threads (#680) #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: branch-25.02
Choose a base branch
from
Open

Java: Fix for a crash situation when using different threads (#680) #705

wants to merge 1 commit into from

Conversation

chatman
Copy link
Contributor

@chatman chatman commented Feb 17, 2025

Using a pool memory manager was causing crash with different threads. Modified a test to run parallely sometimes.

Fix for a crash situation when using different threads (rapidsai#680)
a2b818d 
Using a pool memory manager was causing crash with different threads. Modified a test to run parallely sometimes.

Co-authored-by: Vivek Narang <[email protected]>
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 17, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@chatman chatman changed the title Fix for a crash situation when using different threads (#680) Java: Fix for a crash situation when using different threads (#680) Feb 17, 2025
@chatman chatman changed the base branch from branch-25.04 to branch-25.02 February 17, 2025 06:24
@chatman
Copy link
Contributor Author

chatman commented Feb 17, 2025

Branch 25.04 doesn't have latest Java fixes that 25.02 has. Hence, unable to raise against that branch.

@rhdong rhdong added bug Something isn't working non-breaking Introduces a non-breaking change Java labels Feb 17, 2025
rhdong
rhdong approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong
Copy link
Member

rhdong commented Feb 17, 2025

/ok to test

@rhdong
Copy link
Member

rhdong commented Feb 17, 2025 •
edited
Loading

Hi @cjnolet , would you like this PR could be squashed with #695 ?

@rhdong rhdong mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@rhdong rhdong rhdong approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Java non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chatman @rhdong @cjnolet