Skip to content

Add sklearn as dependency of cuvs-bench #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: branch-25.06
Choose a base branch
from
Open

Add sklearn as dependency of cuvs-bench #709

wants to merge 1 commit into from

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Feb 19, 2025

No description provided.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 19, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cjnolet cjnolet added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 20, 2025
@cjnolet cjnolet marked this pull request as ready for review February 20, 2025 20:15
@cjnolet cjnolet requested a review from a team as a code owner February 20, 2025 20:15
@dantegd dantegd closed this Feb 21, 2025
@dantegd dantegd reopened this Feb 21, 2025
@dantegd dantegd changed the base branch from branch-25.02 to branch-25.04 February 21, 2025 00:10
tarang-jain
tarang-jain requested changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@tarang-jain tarang-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be added to dependencies.yaml under bench_ann and benchmarking conda environments too?

@cjnolet cjnolet changed the base branch from branch-25.04 to branch-25.06 April 23, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarang-jain tarang-jain tarang-jain requested changes

@cjnolet cjnolet cjnolet approved these changes

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@dantegd dantegd

Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantegd @cjnolet @tarang-jain @KyleFromNVIDIA