Add support for half in CAGRA+HNSW #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mickael Ide <[email protected]>
Signed-off-by: Mickael Ide <[email protected]>
lowener
added
non-breaking
divyegala
reviewed
Apr 8, 2025
Signed-off-by: Mickael Ide <[email protected]>
Signed-off-by: Mickael Ide <[email protected]>
divyegala
reviewed
Apr 14, 2025
Signed-off-by: Mickael Ide <[email protected]>
Signed-off-by: Mickael Ide <[email protected]>
|
/ok to test 6660dff |
Signed-off-by: Mickael Ide <[email protected]>
|
/ok to test c6a93c2 |
divyegala
reviewed
Apr 24, 2025
|
/ok to test 72790a4 |
divyegala
approved these changes
Apr 25, 2025
Signed-off-by: Mickael Ide <[email protected]>
|
/ok to test c3c82e1 |
Signed-off-by: Mickael Ide <[email protected]>
|
/ok to test 8f51529 |
|
/ok to test c7c56b5 |
Signed-off-by: Mickael Ide <[email protected]>
|
/ok to test eab0cbe |
|
/merge |
github-project-automation
bot
moved this from In Progress
to Done
in Vector Search, ML, & Data Mining Release Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for half dtype for HNSW in C++, C and python, as well as some tests with it. I had to modify a bit the HNSW patch in order to enable computation on half data types.
I also added the support of inner-product distance for int8/uint8 data type.