Add support for half in CAGRA+HNSW #813
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mickael Ide <[email protected]>
Signed-off-by: Mickael Ide <[email protected]>
lowener
added
non-breaking
divyegala
reviewed
Apr 8, 2025
cpp/src/neighbors/detail/hnsw.hpp
Outdated
| } else if (metric == cuvs::distance::DistanceType::InnerProduct) { | ||
| space_ = std::make_unique<hnswlib::InnerProductSpace>(dim); | ||
| space_ = | ||
| std::make_unique<hnswlib::InnerProductSpace<T, typename hnsw_dist_t<T>::type>>(dim); | ||
| } | ||
| } else if constexpr (std::is_same_v<T, std::int8_t> or std::is_same_v<T, std::uint8_t>) { |
There was a problem hiding this comment.
With your changes to the template functions in hnswlib, I think we should be able to support int8 and uint8 for InnerProduct now?
There was a problem hiding this comment.
True, I added support for that in the PR
Signed-off-by: Mickael Ide <[email protected]>
Signed-off-by: Mickael Ide <[email protected]>
divyegala
reviewed
Apr 14, 2025
Signed-off-by: Mickael Ide <[email protected]>
Signed-off-by: Mickael Ide <[email protected]>
|
/ok to test 6660dff |
Signed-off-by: Mickael Ide <[email protected]>
|
/ok to test c6a93c2 |
divyegala
reviewed
Apr 24, 2025
Comment on lines
91
to
92
| # Note that inner_product tests use normalized input which we cannot | ||
| # represent in int8, therefore we test only sqeuclidean metric here. |
There was a problem hiding this comment.
Can we remove this comment now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for half dtype for HNSW in C++, C and python, as well as some tests with it. I had to modify a bit the HNSW patch in order to enable computation on half data types.
I also added the support of inner-product distance for int8/uint8 data type.