[cuvs_bench] distinguish search label from build label in data_export.py #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `configs/algos/*.yaml` has string configurations, they will be converted into "label" column in exported CSV files. But the exported CSV files only have "label" column for build configuration. search configuration is missing. Before this patch, the search label is overriden by build label in exported CSV files. After this patch, CSV files have "label" column as build label and "search_label" column as search label.
cjnolet
added
improvement
|
/ok to test 6465ac8 |
|
Hello @cjnolet , I have fixed the python code style issue. Could you please trigger the CI again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
configs/algos/*.yamlhas string configurations, they will be converted into "label" column in exported CSV files.But the exported CSV files only have "label" column for build configuration. search configuration is missing.
Before this patch, the search label is overriden by build label in exported CSV files.
After this patch, CSV files have "label" column as build label and "search_label" column as search label.