Skip to content

[CuVS-Java] Automate panama bindings generation, Include IVF_PQ parameters in CAGRA index parameters and other changes #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: branch-25.06
Choose a base branch
from

Conversation

narangvivek10
Copy link

The PR includes code changes for the following:

  • Automation of Panama bindings generation using jextract.
  • Adding the ability to configure IVF_PQ index and search parameters via the cuvs-java API (to adapt with the following underlying changes).
  • Updating HNSW example to show the above.
  • Updating the readme files.
  • Simplifying logging in examples.
  • Bumping up the maven-javadoc-plugin version.
  • Updating and consolidating gitignore file.
  • Removing unused imports etc.

Please note that the existing Panama classes are being deleted because they were manually created and managed. With the new cleaner approach, this will not be needed anymore. Now these binding classes will be generated at build time and so no need to be in the codebase.

Copy link

copy-pr-bot bot commented Apr 21, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rhdong rhdong self-requested a review April 22, 2025 16:31
@rhdong rhdong added bug Something isn't working non-breaking Introduces a non-breaking change Java labels Apr 22, 2025
@narangvivek10 narangvivek10 marked this pull request as ready for review April 22, 2025 16:38
@narangvivek10 narangvivek10 requested a review from a team as a code owner April 22, 2025 16:38
@narangvivek10 narangvivek10 requested a review from jameslamb April 22, 2025 16:38
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong
Copy link
Member

rhdong commented Apr 23, 2025

/ok to test

Copy link

copy-pr-bot bot commented Apr 23, 2025

/ok to test

@rhdong, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@rhdong
Copy link
Member

rhdong commented Apr 23, 2025

/ok to test 806af86

1 similar comment
@cjnolet
Copy link
Member

cjnolet commented Apr 23, 2025

/ok to test 806af86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Java non-breaking Introduces a non-breaking change
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants