Skip to content

feat: add support for Python 3.13 #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025

Conversation

gforsyth
Copy link
Contributor

@gforsyth gforsyth commented May 2, 2025

Description

Contributes to rapidsai/build-planning#120

This PR adds support for Python 3.13.

Notes for Reviewers

This is part of ongoing work to add Python 3.13 support across RAPIDS.
It temporarily introduces a build/test matrix including Python 3.13, from rapidsai/shared-workflows#268.

A follow-up PR will revert back to pointing at the branch-25.06 branch of shared-workflows once all
RAPIDS repos have added Python 3.13 support.

This will fail until all dependencies have been updated to Python 3.13

CI here is expected to fail until all of this project's upstream dependencies support Python 3.13.

This can be merged whenever all CI jobs are passing.

@gforsyth gforsyth requested a review from a team as a code owner May 2, 2025 14:50
@gforsyth gforsyth added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 2, 2025
@gforsyth gforsyth requested a review from a team as a code owner May 2, 2025 14:50
@gforsyth gforsyth requested a review from msarahan May 2, 2025 14:50
@github-actions github-actions bot added the conda conda issue label May 2, 2025
@gforsyth
Copy link
Contributor Author

gforsyth commented May 2, 2025

Ok, this is very annoying. The tests for dask-cuda rely on dask-cudf and cudf, but the tests for dask-cudf rely on dask-cuda. So we can't support Python 3.13 until the other supports it, ad-infinitum.

I'm going to open a Python 3.13 PR to cudf, then use the artifacts from that to test here.

@pentschev
Copy link
Member

If that gets too complicated I'm fine if we can just disable cudf/dask-cudf dependency testing to get this merged first, they are only hard dependencies for testing, so if building a custom matrix for 3.13 is easy we could just do that without cudf/dask-cudf until they get their own packages.

@gforsyth
Copy link
Contributor Author

gforsyth commented May 2, 2025

If that gets too complicated I'm fine if we can just disable cudf/dask-cudf dependency testing to get this merged first, they are only hard dependencies for testing, so if building a custom matrix for 3.13 is easy we could just do that without cudf/dask-cudf until they get their own packages.

Ok, that sounds easier and faster and less headache-inducing. Thanks @pentschev !

@bdice
Copy link
Contributor

bdice commented May 2, 2025

Yes, we typically disable cudf tests in this repo when circular dependencies like this come up.

@gforsyth
Copy link
Contributor Author

gforsyth commented May 2, 2025

/merge

@rapids-bot rapids-bot bot merged commit 90b4524 into rapidsai:branch-25.06 May 2, 2025
37 checks passed
@gforsyth gforsyth deleted the python-3.13 branch May 2, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants