Skip to content

feat: Warn when a dependency set is unused #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KyleFromNVIDIA merged 5 commits into from
Aug 26, 2025
Merged

feat: Warn when a dependency set is unused #163

KyleFromNVIDIA merged 5 commits into from
Aug 26, 2025

Conversation

@KyleFromNVIDIA
Copy link
Member

@KyleFromNVIDIA KyleFromNVIDIA commented Aug 22, 2025 •
edited
Loading

Resolves #162

jameslamb
jameslamb requested changes Aug 22, 2025
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up so quickly!

Leaving a first review, but don't rush because I won't be able to review this again until next week.

jameslamb
jameslamb requested changes Aug 26, 2025
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I'm good with whatever way we go on style for the new CLI flags, the counterexample of python also using -W wasn't something I'd considered.

I just left a few more suggestions, things I didn't think about in my previous review. These are mostly focused on the user experience in a possible future where we had multiple checks like this.

jameslamb
jameslamb approved these changes Aug 26, 2025
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, thanks for considering the suggestions!

I left one more tiny recommendation, otherwise I think we should merge this and roll it out across RAPIDS (whenever you have time and interest).

I'm excited to have this, and to see what other unused stuff it uncovers 😁

@KyleFromNVIDIA KyleFromNVIDIA merged commit 74692c5 into rapidsai:main Aug 26, 2025
5 checks passed
GPUtester pushed a commit that referenced this pull request Aug 26, 2025
@semantic-release-bot
chore(release): 1.20.0 [skip ci]
a32307f 
# [1.20.0](v1.19.2...v1.20.0) (2025-08-26)

### Features

* Warn when a dependency set is unused ([#163](#163)) ([74692c5](74692c5))
@GPUtester
Copy link

GPUtester commented Aug 26, 2025

🎉 This PR is included in version 1.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Aug 26, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
KyleFromNVIDIA added a commit to rapidsai/rapids-build-backend that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#74)
f3681f7 
This PR updates the rapids-dependency-file-generator hook to get
rapidsai/dependency-file-generator#163.
KyleFromNVIDIA added a commit to rapidsai/rapids-metadata that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#62)
62d15c3 
This PR updates the rapids-dependency-file-generator hook to get
rapidsai/dependency-file-generator#163.
rapids-bot bot pushed a commit to rapidsai/rapidsmpf that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#465)
47bcca6 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #465
rapids-bot bot pushed a commit to rapidsai/cucim that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#934)
7d990eb 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #934
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#7141)
39e5e57 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #7141
rapids-bot bot pushed a commit to rapidsai/cuvs that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#1285)
7367263 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #1285
rapids-bot bot pushed a commit to rapidsai/cuxfilter that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#719)
4a0d0a8 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #719
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#1542)
dacfadf 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #1542
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#809)
ecfe488 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #809
rapids-bot bot pushed a commit to rapidsai/nx-cugraph that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#183)
f77ec2a 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #183
rapids-bot bot pushed a commit to rapidsai/rapids-cmake that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#903)
0b11148 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #903
rapids-bot bot pushed a commit to rapidsai/rmm that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#2027)
7cef2f5 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #2027
rapids-bot bot pushed a commit to rapidsai/ucx-py that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#1163)
83fe5f5 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #1163
rapids-bot bot pushed a commit to rapidsai/ucxx that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#492)
4319704 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #492
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#19796)
b5c29e0 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #19796
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Aug 26, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#5240)
5d7ad03 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Brad Rees (https://github.com/BradReesWork)

URL: #5240
@jameslamb jameslamb mentioned this pull request Aug 26, 2025
Merged
rapids-bot bot pushed a commit to rapidsai/cugraph-gnn that referenced this pull request Aug 27, 2025
@KyleFromNVIDIA
Update rapids-dependency-file-generator (#285)
3d4c449 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #285
galipremsagar pushed a commit to galipremsagar/cudf that referenced this pull request Aug 27, 2025
@KyleFromNVIDIA @galipremsagar
Update rapids-dependency-file-generator (rapidsai#19796)
06a4267 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: rapidsai#19796
@jameslamb jameslamb mentioned this pull request Aug 27, 2025
Merged
jameslamb pushed a commit to rapidsai/cumlprims_mg that referenced this pull request Aug 27, 2025
@KyleFromNVIDIA @jameslamb
Update rapids-dependency-file-generator (#283)
0929c7f 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: https://github.com/rapidsai/cumlprims_mg/pull/283
rapids-bot bot pushed a commit to rapidsai/cuvs-lucene that referenced this pull request Aug 27, 2025
@jameslamb
simplify build scripts (#19)
99db89c 
* updates `rapids-dependency-file-generator`, to pull in changes from rapidsai/dependency-file-generator#163
* removes unnecessary error-trapping in shell scripts

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #19
jameslamb pushed a commit to rapidsai/cumlprims_mg that referenced this pull request Aug 27, 2025
@KyleFromNVIDIA @jameslamb
Update rapids-dependency-file-generator (#283)
8b18c7a 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: https://github.com/rapidsai/cumlprims_mg/pull/283
@jameslamb jameslamb mentioned this pull request Aug 28, 2025
Merged
8 tasks
rapids-bot bot pushed a commit to NVIDIA/cuopt that referenced this pull request Aug 29, 2025
@jameslamb
use GCC 14, consolidate dependency groups, update pre-commit hooks (#358
9006ad7 
)

Contributes to rapidsai/build-planning#208 and #294, by doing some of the pre-work to support CUDA 13

* updates from GCC 13 to GCC 14 (ref: rapidsai/build-planning#188)
* consolidates some dependency groups in `dependencies.yaml` marked with `cuda: "12.*"` that also should apply for CUDA 13

Other small packaging / CI changes:

* updates to latest versions of all RAPIDS `pre-commit` hooks
  - *including the new `--strict` flag for `rapids-dependency-file-generator` from rapidsai/dependency-file-generator#163
* removes empty `conda/recipes/cuopt-sh-client/conda_build_config.yaml`

## Issue

#294

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ramakrishnap (https://github.com/rgsl888prabhu)

URL: #358
aliceb-nv pushed a commit to NVIDIA/cuopt that referenced this pull request Sep 1, 2025
@jameslamb @aliceb-nv
use GCC 14, consolidate dependency groups, update pre-commit hooks (#358
480c4f1 
)

Contributes to rapidsai/build-planning#208 and #294, by doing some of the pre-work to support CUDA 13

* updates from GCC 13 to GCC 14 (ref: rapidsai/build-planning#188)
* consolidates some dependency groups in `dependencies.yaml` marked with `cuda: "12.*"` that also should apply for CUDA 13

Other small packaging / CI changes:

* updates to latest versions of all RAPIDS `pre-commit` hooks
  - *including the new `--strict` flag for `rapids-dependency-file-generator` from rapidsai/dependency-file-generator#163
* removes empty `conda/recipes/cuopt-sh-client/conda_build_config.yaml`

## Issue

#294

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ramakrishnap (https://github.com/rgsl888prabhu)

URL: #358
rapids-bot bot pushed a commit to rapidsai/cugraph-docs that referenced this pull request Sep 5, 2025
@jameslamb
build and test with CUDA 13.0.0 (#154)
7ba9c85 
Contributes to rapidsai/build-planning#208

* uses CUDA 13.0.0 to build and test
* updates to latest versions of all `pre-commit` hooks (including stricter `rapids-dependency-file-generator` via rapidsai/dependency-file-generator#163)

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Don Acosta (https://github.com/acostadon)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #154
jameslamb pushed a commit to rapidsai/cumlprims_mg that referenced this pull request Sep 8, 2025
@KyleFromNVIDIA @jameslamb
Update rapids-dependency-file-generator (#283)
d7666cf 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: https://github.com/rapidsai/cumlprims_mg/pull/283
jameslamb pushed a commit to rapidsai/cumlprims_mg that referenced this pull request Sep 10, 2025
@KyleFromNVIDIA @jameslamb
Update rapids-dependency-file-generator (#283)
644bbda 
This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: https://github.com/rapidsai/cumlprims_mg/pull/283
AyodeAwe added a commit to rapidsai/cumlprims_mg that referenced this pull request Oct 8, 2025
@AyodeAwe @GPUtester
@bdice @vyasr @robertmaynard @trxcllnt @jameslamb @KyleFromNVIDIA @dantegd @csadorf @msarahan
[RELEASE] cumlprims_mg v25.10 (#12)
59bc87d 
* DOC v25.10 Updates [skip ci]

* merge pull request 275 from rapidsai/branch-25.08

* Allow latest OS in devcontainers (#276)

This PR removes the OS suffix from devcontainers, allowing the upstream devcontainer images to determine the OS version.

Contributes to rapidsai/build-planning#200.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: https://github.com/rapidsai/cumlprims_mg/pull/276

* Use GCC 14 in conda builds. (#265)

conda-forge is migrating to gcc 14, so this PR is updating for alignment.

See rapidsai/build-planning#188

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Gil Forsyth (https://github.com/gforsyth)

URL: https://github.com/rapidsai/cumlprims_mg/pull/265

* Update build infra to support new branching strategy (#273)

rapids_config will use `RAPIDS_BRANCH` contents to determine what branch to use

Authors:
  - Robert Maynard (https://github.com/robertmaynard)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: https://github.com/rapidsai/cumlprims_mg/pull/273

* RAPIDS dependency now use the new rapids-cmake branch info (#278)

This is required to handle when we switch RAPIDS branching strategy

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: https://github.com/rapidsai/cumlprims_mg/pull/278

* Use rapids_cuda_enable_fatbin_compression (#280)

Standardize compression flags via rapids_cuda_enable_fatbin_compression

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: https://github.com/rapidsai/cumlprims_mg/pull/280

* Use build cluster in devcontainers (#281)

RAPIDS has deployed an autoscaling cloud build cluster that can be used to accelerate building large RAPIDS projects. This contributes to rapidsai/build-planning#209.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Bradley Dice (https://github.com/bdice)

URL: https://github.com/rapidsai/cumlprims_mg/pull/281

* Build and test with CUDA 13.0.0 (#282)

Contributes to rapidsai/build-planning#208

* uses CUDA 13.0.0 to build and test
* adds CUDA 13 devcontainers

Contributes to rapidsai/build-planning#68

* updates to CUDA 13 dependencies in fallback entries in `dependencies.yaml` matrices (i.e., the ones that get written to `pyproject.toml` in source control)

## Notes for Reviewers

This switches GitHub Actions workflows to the `cuda13.0` branch from here: rapidsai/shared-workflows#413

A future round of PRs will revert that back to `branch-25.10`, once all of RAPIDS supports CUDA 13.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: https://github.com/rapidsai/cumlprims_mg/pull/282

* Update rapids-dependency-file-generator (#283)

This PR updates the rapids-dependency-file-generator hook to get rapidsai/dependency-file-generator#163.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: https://github.com/rapidsai/cumlprims_mg/pull/283

* Open Source license and headers

* open source prep: docs and copyright updates

* Update README (#2)

* Update README

* fix branch references

---------

Co-authored-by: James Lamb <[email protected]>

* update pre-commit hooks (#3)

Updates all pre-commit hooks with `pre-commit autoupdate`.

## Notes for Reviewers

Using this to test CI.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #3

* hide RAFT #pragma deprecation warnings (#4)

* hide RAFT #pragma deprecation warnings

* add -DDISABLE_DEPRECATION_WARNING=ON

* rename DISABLE_DEPRECATION_WARNING -> DISABLE_DEPRECATION_WARNINGS

* Fix typos and improve clarity in README.md (#6)

- Fix "muti-node" → "multi-node" typo
- Add missing colon after "conda" in bullet point
- Capitalize "GitHub" properly
- Fix "succesfully" → "successfully" typo
- Fix broken link reference to custom build options section

Authors:
  - Simon Adorf (https://github.com/csadorf)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #6

* configuring repo for automatic release notes generation (#7)

* Empty commit to trigger a build (#10)

* Fix missed deps in update-version.sh (#13)

---------

Co-authored-by: gpuCI <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Vyas Ramasubramani <[email protected]>
Co-authored-by: Robert Maynard <[email protected]>
Co-authored-by: Paul Taylor <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: Kyle Edwards <[email protected]>
Co-authored-by: Dante Gama Dessavre <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: Simon Adorf <[email protected]>
Co-authored-by: Mike Sarahan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jameslamb jameslamb jameslamb approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature request: detect unused dependency lists

3 participants

@KyleFromNVIDIA @GPUtester @jameslamb