Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package names in manifest for dask-cudf and cudf-polars #471

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Mar 5, 2025

Although the subdirectories have underscores, the advertised package names have hyphens. Without this, we end up depending on dask-cudf in the combined conda dev environment that then pulls in cudf. sadtimes.gif

Although the subdirectories have underscores, the advertised package
names have hyphens. Without this, we end up depending on dask-cudf in
the combined conda dev environment that then pulls in cudf. sadtimes.gif
@wence- wence- requested a review from a team as a code owner March 5, 2025 11:28
@wence- wence- requested review from KyleFromNVIDIA and removed request for a team March 5, 2025 11:28
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh whoa! This is a good fix, thank you.

@jameslamb jameslamb removed the request for review from KyleFromNVIDIA March 5, 2025 15:06
@trxcllnt trxcllnt merged commit 30a91f6 into rapidsai:branch-25.04 Mar 5, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants