Skip to content

Update to CUDA 12.9.0 #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025
+20 −19
Merged

Update to CUDA 12.9.0 #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a6d0ea
Update to CUDA 12.9.0
bdice May 8, 2025
e3dcc39
Apply suggestions from code review
trxcllnt May 8, 2025
4a29bbd
Revert RAPIDS max version and devcontainers to 12.8.
bdice May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/src/cuda/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ A feature to install the NVIDIA CUDA Toolkit

| Options Id | Description | Type | Default Value |
|-----|-----|-----|-----|
| version | Version of the CUDA Toolkit to install. | string | 12.8 |
| version | Version of the CUDA Toolkit to install. | string | 12.9 |
| cuDNNVersion | Version of cuDNN to install. | string | 8 |
| installCompilers | Install NVIDIA CUDA Compiler (nvcc) | boolean | true |
| installProfilers | Install NVIDIA NSight Systems Profiler (nsys) | boolean | true |
Expand Down
3 changes: 2 additions & 1 deletion features/src/cuda/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"version": {
"type": "string",
"proposals": [
"12.9",
"12.8",
"12.6",
"12.5",
Expand All @@ -24,7 +25,7 @@
"11.2",
"11.1"
],
"default": "12.8",
"default": "12.9",
"description": "Version of the CUDA Toolkit to install."
},
"cuDNNVersion": {
Expand Down
2 changes: 1 addition & 1 deletion features/src/cuda/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export OSNAME="$(
echo "$ID$((major - (major % 2)))${minor}";
)";

VERSION="${CUDA_VERSION:-${VERSION:-12.8.0}}";
VERSION="${CUDA_VERSION:-${VERSION:-12.9.0}}";

if [[ "$NVARCH" == aarch64 ]]; then
NVARCH="sbsa";
Expand Down
6 changes: 3 additions & 3 deletions features/test/_global/cpp_llvm_cuda_nvhpc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ source dev-container-features-test-lib;
check "gitlab-cli version" glab --version

# Check CUDA
check "CUDA version" bash -c "echo '$CUDA_VERSION' | grep '12.8.0'";
check "CUDA version" bash -c "echo '$CUDA_VERSION' | grep '12.9.0'";
check "CUDA major version" bash -c "echo '$CUDA_VERSION_MAJOR' | grep '12'";
check "CUDA minor version" bash -c "echo '$CUDA_VERSION_MINOR' | grep '8'";
check "CUDA minor version" bash -c "echo '$CUDA_VERSION_MINOR' | grep '9'";
check "CUDA patch version" bash -c "echo '$CUDA_VERSION_PATCH' | grep '0'";
check "installed" stat /usr/local/cuda-12.8 /usr/local/cuda;
check "installed" stat /usr/local/cuda-12.9 /usr/local/cuda;
check "nvcc exists and is on path" which nvcc;

# Check NVHPC
Expand Down
6 changes: 3 additions & 3 deletions features/test/_global/cuda_rust.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ source dev-container-features-test-lib;
>&2 echo "BASH_ENV=$BASH_ENV";

# Check CUDA
check "CUDA version" bash -c "echo '$CUDA_VERSION' | grep '12.8.0'";
check "CUDA version" bash -c "echo '$CUDA_VERSION' | grep '12.9.0'";
check "CUDA major version" bash -c "echo '$CUDA_VERSION_MAJOR' | grep '12'";
check "CUDA minor version" bash -c "echo '$CUDA_VERSION_MINOR' | grep '8'";
check "CUDA minor version" bash -c "echo '$CUDA_VERSION_MINOR' | grep '9'";
check "CUDA patch version" bash -c "echo '$CUDA_VERSION_PATCH' | grep '0'";
check "installed" stat /usr/local/cuda-12.8 /usr/local/cuda;
check "installed" stat /usr/local/cuda-12.9 /usr/local/cuda;
check "nvcc exists and is on path" which nvcc;

# Check Rust
Expand Down
4 changes: 2 additions & 2 deletions features/test/_global/scenarios.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"features": {
"rust": {},
"cuda": {
"version": "12.8"
"version": "12.9"
}
},
"overrideFeatureInstallOrder": [
Expand Down Expand Up @@ -44,7 +44,7 @@
"version": "16"
},
"cuda": {
"version": "12.8"
"version": "12.9"
},
"nvhpc": {
"version": "24.5"
Expand Down
6 changes: 3 additions & 3 deletions features/test/cuda/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ source dev-container-features-test-lib

# Feature-specific tests
# The 'check' command comes from the dev-container-features-test-lib.
check "CUDA version" bash -c "echo '$CUDA_VERSION' | grep '12.8.0'";
check "CUDA version" bash -c "echo '$CUDA_VERSION' | grep '12.9.0'";
check "CUDA major version" bash -c "echo '$CUDA_VERSION_MAJOR' | grep '12'";
check "CUDA minor version" bash -c "echo '$CUDA_VERSION_MINOR' | grep '8'";
check "CUDA minor version" bash -c "echo '$CUDA_VERSION_MINOR' | grep '9'";
check "CUDA patch version" bash -c "echo '$CUDA_VERSION_PATCH' | grep '0'";
check "installed" stat /usr/local/cuda-12.8 /usr/local/cuda
check "installed" stat /usr/local/cuda-12.9 /usr/local/cuda
check "nvcc exists and is on path" which nvcc

# Report result
Expand Down
2 changes: 1 addition & 1 deletion features/test/openmpi/scenarios.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"image": "ubuntu:22.04",
"features": {
"cuda": {
"version": "12.8"
"version": "12.9"
},
"ucx": {
"version": "1.15.0"
Expand Down
4 changes: 2 additions & 2 deletions features/test/ucx/scenarios.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"image": "ubuntu:22.04",
"features": {
"cuda": {
"version": "12.8"
"version": "12.9"
},
"ucx": {
"version": "1.14.1"
Expand All @@ -18,7 +18,7 @@
"image": "ubuntu:22.04",
"features": {
"cuda": {
"version": "12.8"
"version": "12.9"
},
"ucx": {
"version": "1.15.0-rc3"
Expand Down
4 changes: 2 additions & 2 deletions windows/image/installers/install-cuda.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Param(
[Parameter(Mandatory=$false)]
[string]
$cudaVersion="12.8.0"
$cudaVersion="12.9.0"
)

# Use System.Version to tokenize version
Expand All @@ -11,7 +11,7 @@ $major = $version.Major
$minor = $version.Minor
$build = $version.Build

# Minimum build is 0, not -1 as default in case "12.8" is passed
# Minimum build is 0, not -1 as default in case "12.9" is passed
if ($build -lt 0) {
$build = 0
}
Expand Down